Fix release script empty version display#638
Merged
Merged
Conversation
The release script was echoing $oldver before it was assigned, resulting in "Old version is " with no version number shown. Moved the variable assignments (oldver, oldVerUnderscore, vOldVerUnderscoreFinal) to before the echo statement so the version is extracted from package.json before being displayed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #637
Summary
Problem
The script was trying to echo
$oldverbefore it was assigned, resulting in:Solution
Moved the variable assignments (lines 67-69) to before the echo statement (line 64) so the version is extracted from
package.jsonbefore being displayed.Test plan
🤖 Generated with Claude Code