Skip to content

Conversation

@nickboldt
Copy link
Member

@nickboldt nickboldt commented Jan 27, 2026

What does this PR do?

chore: support konflux's ugly config implementation for annotations so we can extract the package path (RHDHBUGS-2530)
assisted-by: cursor

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

(RHDHBUGS-2530)

How to test this PR?

pytest test_install-dynamic-plugins.py::TestOciDownloader::test_get_oci_plugin_paths_real_image -v -s

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…o we can extract the package path (RHDHBUGS-2530)

Assisted-by: Cursor

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt force-pushed the implement-konflux-annotation-reader branch from 3d572c8 to 383495e Compare January 27, 2026 21:29
@sonarqubecloud
Copy link

@nickboldt
Copy link
Member Author

/cherry-pick release-1.9

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Zaperex
Copy link
Member

Zaperex commented Jan 27, 2026

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Zaperex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

@nickboldt
Copy link
Member Author

hermeto validation passed with:

2026-01-27 22:07:07,648 INFO All dependencies fetched successfully \o/

@nickboldt nickboldt merged commit dab2a2e into main Jan 27, 2026
18 of 19 checks passed
@nickboldt nickboldt deleted the implement-konflux-annotation-reader branch January 27, 2026 23:36
@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: new pull request created: #4082

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nickboldt
Copy link
Member Author

merged, building in https://gitlab.cee.redhat.com/rhidp/rhdh/-/pipelines/14326738 to verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants