chore: clean up translation files #4051
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -0,0 +1,731 @@ | |||
| { | |||
| "api-docs": { | |||
| "en": { | |||
There was a problem hiding this comment.
| "en": { | |
| "ja": { |
This should be changed in all other places too.
| @@ -0,0 +1,731 @@ | |||
| { | |||
| "api-docs": { | |||
| "en": { | |||
There was a problem hiding this comment.
| "en": { | |
| "it": { |
| } | ||
| }, | ||
| "kubernetes-cluster": { | ||
| "en": { |
There was a problem hiding this comment.
| "en": { | |
| "it": { |
Change this in the rest of the file.
|
The image is available at: |
ciiay
force-pushed
the
translation-support-clean-up
branch
from
d4b41db to
eb4d452
Compare
|
The image is available at: |
ciiay
force-pushed
the
translation-support-clean-up
branch
from
eb4d452 to
d8d8b3c
Compare
|
The image is available at: |
ciiay
force-pushed
the
translation-support-clean-up
branch
from
d8d8b3c to
4564786
Compare
|
The image is available at: |
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
force-pushed
the
translation-support-clean-up
branch
from
4564786 to
3207784
Compare
|
|
The image is available at: |
|
@ciiay: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
karthikjeeyar
left a comment
karthikjeeyar
left a comment
There was a problem hiding this comment.
Verified the PR changes using the PR image, looks good to me.
I have noticed a place where there is some manual correction needed. PTAL
| "fr": { | ||
| "catalogFilter.title": "Filtres", | ||
| "catalogFilter.buttonTitle": "Filtres", | ||
| "entityKindPicker.title": "Type", |
There was a problem hiding this comment.
This is not translated in french and also it has incorrect value "Type" instead of "Kind" and Ideally this should be translated (Maybe we can use AI for this for now).
| "entityKindPicker.title": "Type", | |
| "entityKindPicker.title": "Kind", |
There was a problem hiding this comment.
Hi @karthikjeeyar , the "Type" is already a translated word. The thing is in French both "kind" and "type" are "type". I consulted AI regarding translation of
"entityTypePicker.title": "Type",
"entityKindPicker.title": "Kind",
when they are together, AI suggested
"entityTypePicker.title": "Type",
"entityKindPicker.title": "Catégorie"
As in Backstage, Kind and Type have different meanings:
- Kind = entity category (Component, API, Resource, System, Group, User…)
- Type = subtype within a Kind (service, website, library…)
What do you think? If it looks good to you, I will go ahead and update other similar cases to keep everything consistent in French.
- Treat Kind = high-level entity classification: Entity class (Component, API, Resource…)
- Treat Type = subtype / functional type: Subtype (service, website…)
2 participants
Description
Cleaned up translation files with latest it, ja and fr translation for backstage.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer