Skip to content

[Notebooks] UI fixes#3062

Open
JslYoon wants to merge 14 commits intoredhat-developer:mainfrom
JslYoon:JslYoon-UI-fixes
Open

[Notebooks] UI fixes#3062
JslYoon wants to merge 14 commits intoredhat-developer:mainfrom
JslYoon:JslYoon-UI-fixes

Conversation

@JslYoon
Copy link
Copy Markdown
Contributor

@JslYoon JslYoon commented May 6, 2026

Hey, I just made a Pull Request!

  • Hide notebooks tab when lightspeed.notebooks.enabled: false in config
  • Fix notebook queries to display correct model from config instead of chat's selected model
  • Add /notebook-conversation-ids endpoint to filter notebook conversations from chat list even when notebooks disabled
  • lightspeed doesn't crash when Notebooks is enabled but querydefualts is empty

Addressing bugs:
https://redhat.atlassian.net/browse/RHDHBUGS-3097
https://redhat.atlassian.net/browse/RHDHBUGS-3105
https://redhat.atlassian.net/browse/RHDHBUGS-3098
https://redhat.atlassian.net/browse/RHDHBUGS-3111

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
image image

JslYoon added 3 commits May 6, 2026 16:11
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented May 6, 2026

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-lightspeed-backend workspaces/lightspeed/plugins/lightspeed-backend minor v2.6.6
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed minor v2.6.6

@JslYoon
Copy link
Copy Markdown
Contributor Author

JslYoon commented May 6, 2026

/review

JslYoon added 2 commits May 6, 2026 16:39
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
@JslYoon JslYoon requested a review from its-mitesh-kumar May 6, 2026 20:41
Signed-off-by: Lucas <lyoon@redhat.com>
@JslYoon JslYoon marked this pull request as ready for review May 6, 2026 20:47
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 37.70492% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.26%. Comparing base (fc38238) to head (94eca39).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3062      +/-   ##
==========================================
- Coverage   57.28%   57.26%   -0.03%     
==========================================
  Files        2067     2068       +1     
  Lines       63528    63576      +48     
  Branches    16583    16596      +13     
==========================================
+ Hits        36390    36404      +14     
- Misses      26704    26738      +34     
  Partials      434      434              
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from ee46072
ai-integrations 70.03% <ø> (ø) Carriedforward from ee46072
app-defaults 69.60% <ø> (ø) Carriedforward from ee46072
augment 69.36% <ø> (ø) Carriedforward from ee46072
bulk-import 72.44% <ø> (ø) Carriedforward from ee46072
cost-management 16.49% <ø> (ø) Carriedforward from ee46072
dcm 32.85% <ø> (ø) Carriedforward from ee46072
extensions 61.71% <ø> (ø) Carriedforward from ee46072
global-floating-action-button 73.75% <ø> (ø) Carriedforward from ee46072
global-header 61.68% <ø> (ø) Carriedforward from ee46072
homepage 50.92% <ø> (ø) Carriedforward from ee46072
konflux 91.01% <ø> (ø) Carriedforward from ee46072
lightspeed 69.56% <37.70%> (-0.36%) ⬇️
mcp-integrations 81.59% <ø> (ø) Carriedforward from ee46072
orchestrator 34.80% <ø> (ø) Carriedforward from ee46072
quickstart 62.64% <ø> (ø) Carriedforward from ee46072
sandbox 79.56% <ø> (ø) Carriedforward from ee46072
scorecard 83.61% <ø> (ø) Carriedforward from ee46072
theme 64.54% <ø> (ø) Carriedforward from ee46072
translations 8.49% <ø> (ø) Carriedforward from ee46072
x2a 17.29% <ø> (ø) Carriedforward from ee46072

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc38238...94eca39. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HusneShabbir HusneShabbir self-assigned this May 7, 2026
Signed-off-by: Lucas <lyoon@redhat.com>
Copy link
Copy Markdown
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When notebook is not enabled , there should be no tab, it should be as it was before notebook feature.

@JslYoon JslYoon changed the title Jsl yoon UI fixes [Notebooks] UI fixes May 7, 2026
@JslYoon JslYoon requested a review from its-mitesh-kumar May 7, 2026 20:20
Signed-off-by: Lucas <lyoon@redhat.com>
Copy link
Copy Markdown
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend code changes looks good, Upload the latest screen recording and get the CI pass. Then I will verify it by running it locally.

Signed-off-by: Lucas <lyoon@redhat.com>
JslYoon added 2 commits May 7, 2026 19:54
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve noticed a couple of deviations:

  • The Lightspeed header appears off when the notebook tab is not enabled. You can refer to the rolling demo for reference—I’ve also attached a recording.
Screen.Recording.2026-05-08.at.2.50.58.PM.mov
Screen.Recording.2026-05-08.at.2.51.23.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants