[Notebooks] UI fixes#3062
Conversation
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Changed Packages
|
|
/review |
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
==========================================
- Coverage 57.28% 57.26% -0.03%
==========================================
Files 2067 2068 +1
Lines 63528 63576 +48
Branches 16583 16596 +13
==========================================
+ Hits 36390 36404 +14
- Misses 26704 26738 +34
Partials 434 434
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
its-mitesh-kumar
left a comment
There was a problem hiding this comment.
When notebook is not enabled , there should be no tab, it should be as it was before notebook feature.
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
its-mitesh-kumar
left a comment
There was a problem hiding this comment.
Frontend code changes looks good, Upload the latest screen recording and get the CI pass. Then I will verify it by running it locally.
Signed-off-by: Lucas <lyoon@redhat.com>
|
There was a problem hiding this comment.
I’ve noticed a couple of deviations:
- The Lightspeed header appears off when the notebook tab is not enabled. You can refer to the rolling demo for reference—I’ve also attached a recording.
Screen.Recording.2026-05-08.at.2.50.58.PM.mov
- Even after setting
lightspeed.notebooks.enabled: false, navigating to http://localhost:3000/lightspeed/notebooks still displays the notebook tab. This doesn’t seem to match the expected behavior.



Hey, I just made a Pull Request!
lightspeed.notebooks.enabled: falsein config/notebook-conversation-idsendpoint to filter notebook conversations from chat list even when notebooks disabledAddressing bugs:
https://redhat.atlassian.net/browse/RHDHBUGS-3097
https://redhat.atlassian.net/browse/RHDHBUGS-3105
https://redhat.atlassian.net/browse/RHDHBUGS-3098
https://redhat.atlassian.net/browse/RHDHBUGS-3111
✔️ Checklist