Skip to content

chore: update Qodo config to v2#188

Merged
rm3l merged 2 commits intoredhat-developer:mainfrom
zdrapela:qodo-v2-update
Mar 30, 2026
Merged

chore: update Qodo config to v2#188
rm3l merged 2 commits intoredhat-developer:mainfrom
zdrapela:qodo-v2-update

Conversation

@zdrapela
Copy link
Copy Markdown
Member

@zdrapela zdrapela commented Mar 25, 2026

@rhdh-qodo-merge
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Config Types

Several config values appear to be set as quoted strings (e.g., "true"/"false") rather than TOML booleans. Confirm whether Qodo v2 expects actual booleans here; if so, use true/false without quotes to avoid the agent ignoring or misinterpreting these settings.

[checks]
enable_auto_checks_feedback = "true"
persistent_comment = "true"
final_update_message = "false"
Supply Chain

The workflow updates tombi to a new version and checksum. Validate that the pinned tool version matches the provided checksum and that the action version/comment aligns with the intended release, to prevent CI breakages or integrity-check failures.

- uses: tombi-toml/setup-tombi@cebfd308ba02edadfcee148b7473536990950c92 # v1.0.8
  with:
    version: 'v0.9.9'
    checksum: 'b50dbc90ec27591dbaf564b628bd3b3e4ead371a60931bc8ea5f34d7cd1d3607'
📄 References
  1. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1816-1824]
  2. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1794-1816]
  3. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [271-310]
  4. redhat-developer/rhdh/scripts/rhdh-openshift-setup/values.yaml [324-336]
  5. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2895-2927]
  6. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [431-438]
  7. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2263-2279]
  8. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1824-1826]

@rhdh-qodo-merge
Copy link
Copy Markdown
Contributor

PR Type

Enhancement, Configuration changes


Description

  • Update Qodo configuration from v1 to v2 with new command structure

  • Migrate JIRA URL to Atlassian cloud and remove API token reference

  • Replace legacy review/describe commands with agentic equivalents

  • Reorganize configuration sections and update TOML validator version


File Walkthrough

Relevant files
Dependencies
toml-checks.yaml
Update TOML validator to v0.9.9                                                   

.github/workflows/toml-checks.yaml

  • Update tombi-toml action version tag from v1 to v1.0.8
  • Bump TOML validator version from v0.6.3 to v0.9.9
  • Update checksum for new validator version
+3/-3     
Configuration changes
.pr_agent.toml
Migrate to Qodo v2 configuration format                                   

.pr_agent.toml

  • Replace /review and /describe commands with /agentic_review and
    /agentic_describe
  • Add new /generate_labels command to pr_commands
  • Migrate JIRA URL from issues.redhat.com to redhat.atlassian.net
  • Remove jira_api_token and feedback_on_draft_pr settings
  • Restructure configuration sections: consolidate review settings into
    [review_agent], create new [pr_test] and [checks] sections
  • Simplify configuration by removing enable_pr_diagram,
    commitable_code_suggestions, and other deprecated options
+12/-22 

@rhdh-qodo-merge
Copy link
Copy Markdown
Contributor

rhdh-qodo-merge bot commented Mar 25, 2026

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
The PR may unintentionally disable existing review checks

The suggestion questions if the removal of require_ticket_analysis_review = true
during the v2 configuration migration is intentional, as the new configuration
does not explicitly preserve this quality gate. It recommends clarifying this
potential impact.

Examples:

.pr_agent.toml [15-21]
[review_agent]
comments_location_policy = "summary"

[checks]
enable_auto_checks_feedback = "true"
persistent_comment = "true"
final_update_message = "false"

Solution Walkthrough:

Before:

# .pr_agent.toml
[pr_reviewer] # /review #
persistent_comment = true
require_tests_review = false
require_ticket_analysis_review = true
enable_review_labels_security = true
enable_review_labels_effort = true

After:

# .pr_agent.toml
# The [pr_reviewer] section is removed.

[review_agent]
comments_location_policy = "summary"

[checks]
enable_auto_checks_feedback = "true"
persistent_comment = "true"
final_update_message = "false"
# It is unclear if the functionality of 'require_ticket_analysis_review' is preserved.
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies the removal of the require_ticket_analysis_review setting, raising a valid and significant concern about a potential loss of a critical quality gate in the PR review process.

Medium
Possible issue
Use boolean types
Suggestion Impact:Updated the TOML config to use boolean literals for enable_auto_checks_feedback, persistent_comment, and final_update_message instead of quoted strings.

code diff:

-enable_auto_checks_feedback = "true"
-persistent_comment = "true"
-final_update_message = "false"
+enable_auto_checks_feedback = true
+persistent_comment = true
+final_update_message = false

Replace string values like "true" and "false" with boolean literals true and
false in the TOML configuration for correct parsing.

.pr_agent.toml [19-21]

-enable_auto_checks_feedback = "true"
-persistent_comment = "true"
-final_update_message = "false"
+enable_auto_checks_feedback = true
+persistent_comment = true
+final_update_message = false

[Suggestion processed]

Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that string literals are used for boolean values in the TOML configuration, which could lead to misinterpretation and incorrect behavior.

Medium
  • Update

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/override "docker compose - developer-lightspeed-safety-guard"

Unrelated

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

@rm3l: Overrode contexts on behalf of rm3l: docker compose - developer-lightspeed-safety-guard

Details

In response to this:

/override "docker compose - developer-lightspeed-safety-guard"

Unrelated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rm3l rm3l merged commit 1490af1 into redhat-developer:main Mar 30, 2026
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants