Skip to content

chore: update Qodo config to v2#334

Merged
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:mainfrom
zdrapela:qodo-v2-update
Mar 26, 2026
Merged

chore: update Qodo config to v2#334
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:mainfrom
zdrapela:qodo-v2-update

Conversation

@zdrapela
Copy link
Copy Markdown
Member

@zdrapela zdrapela commented Mar 25, 2026

Description

Update to the Qodo configuration to v2: https://docs.qodo.ai/code-review/migrating-to-qodo-v2
Update tombi-toml/setup-tombi to v1.0.8 with tombi v0.9.9.

Mirrors redhat-developer/rhdh#4460.

https://redhat.atlassian.net/browse/RHIDP-12920

@rhdh-qodo-merge
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Type Mismatch

Several config values that look like booleans are set as quoted strings (e.g., "true"/"false"). Confirm whether Qodo v2 expects actual TOML booleans for these fields; otherwise the settings may be ignored or misinterpreted.

[checks]
enable_auto_checks_feedback = "true"
persistent_comment = "true"
final_update_message = "false"
Supply Chain

The Tombi tool version and checksum were updated. Validate that the checksum corresponds exactly to the specified version and that the action/tool invocation still behaves as expected for linting in CI.

- uses: tombi-toml/setup-tombi@cebfd308ba02edadfcee148b7473536990950c92 # v1.0.8
  with:
    version: 'v0.9.9'
    checksum: 'b50dbc90ec27591dbaf564b628bd3b3e4ead371a60931bc8ea5f34d7cd1d3607'
- name: Validate TOML files
  run: tombi lint
📄 References
  1. redhat-developer/rhdh-chart/ct-install.yaml [1-11]
  2. redhat-developer/rhdh-chart/charts/orchestrator-software-templates/templates/tekton/tekton-tasks.yaml [117-151]
  3. redhat-developer/rhdh/rpms.in.yaml [1-11]
  4. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2263-2279]
  5. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1816-1824]
  6. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1824-1826]
  7. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2895-2927]
  8. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1794-1816]

@rhdh-qodo-merge rhdh-qodo-merge bot added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 25, 2026
@rhdh-qodo-merge
Copy link
Copy Markdown

PR Type

Enhancement, Documentation


Description

  • Update Qodo configuration from v1 to v2 with new command structure

  • Upgrade tombi-toml/setup-tombi to v1.0.8 with tombi v0.9.9

  • Restructure PR agent configuration with new section organization

  • Update JIRA base URL and simplify API token configuration


File Walkthrough

Relevant files
Dependencies
toml-checks.yaml
Upgrade tombi-toml/setup-tombi and tombi versions               

.github/workflows/toml-checks.yaml

  • Upgrade tombi-toml/setup-tombi action from v1 to v1.0.8
  • Update tombi version from v0.6.3 to v0.9.9
  • Update checksum for new tombi version
  • Fix missing newline at end of file
+4/-4     
Configuration changes
.pr_agent.toml
Migrate Qodo configuration to v2 format                                   

.pr_agent.toml

  • Migrate Qodo configuration from v1 to v2 format
  • Replace /review, /describe, /improve commands with /agentic_review,
    /agentic_describe, /generate_labels
  • Reorganize configuration sections: consolidate pr_reviewer and
    pr_description into review_agent and checks
  • Update JIRA base URL from issues.redhat.com to redhat.atlassian.net
  • Remove jira_api_token from config (use secrets instead)
  • Disable pr_test and adjust various feature flags
+12/-22 

@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge bot commented Mar 25, 2026

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Clarify removal of standalone improve command

The PR removes the /improve command during the v2 migration but does not add its
replacement, /agentic_improve. This change in available tools should be
confirmed as intentional.

Examples:

.pr_agent.toml [6-10]
pr_commands = [
    "/agentic_review",
    "/agentic_describe --pr_description.final_update_message=false",
    "/generate_labels",
]

Solution Walkthrough:

Before:

# .pr_agent.toml
[github_app]
pr_commands = [
    "/review",
    "/describe ...",
    "/improve",
]

After:

# .pr_agent.toml
[github_app]
pr_commands = [
    "/agentic_review",
    "/agentic_describe ...",
    "/generate_labels",
]
# Note: /agentic_improve is not added
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies the removal of the /improve command without adding its v2 equivalent, raising a valid question about a potentially incomplete migration and its impact on developer workflow.

Medium
Possible issue
Use booleans instead of strings
Suggestion Impact:Updated enable_auto_checks_feedback, persistent_comment, and final_update_message from quoted "true"/"false" strings to unquoted boolean literals true/false in the [checks] section.

code diff:

 [checks]
-enable_auto_checks_feedback = "true"
-persistent_comment = "true"
-final_update_message = "false"
+enable_auto_checks_feedback = true
+persistent_comment = true
+final_update_message = false

In the [checks] section of the TOML file, change the string values for
enable_auto_checks_feedback, persistent_comment, and final_update_message to
boolean literals.

.pr_agent.toml [18-21]

 [checks]
-enable_auto_checks_feedback = "true"
-persistent_comment = "true"
-final_update_message = "false"
+enable_auto_checks_feedback = true
+persistent_comment = true
+final_update_message = false

[Suggestion processed]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that boolean values in the [checks] section are incorrectly formatted as strings, which could lead to parsing errors and is inconsistent with other boolean flags in the same file.

Low
General
Pin action by semver tag

Pin the tombi-toml/setup-tombi action using its version tag v1.0.8 instead of
the commit SHA for better readability.

.github/workflows/toml-checks.yaml [16]

-- uses: tombi-toml/setup-tombi@cebfd308ba02edadfcee148b7473536990950c92 # v1.0.8
+- uses: tombi-toml/setup-tombi@v1.0.8
  • Apply / Chat
Suggestion importance[1-10]: 3

__

Why: The suggestion offers a stylistic alternative for pinning a GitHub action; while using a tag can improve readability, pinning by SHA is a valid and more secure practice, making this a low-impact preference.

Low
  • Update

@sonarqubecloud
Copy link
Copy Markdown

@openshift-ci openshift-ci bot added the lgtm label Mar 26, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 8e435fd into redhat-developer:main Mar 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request lgtm Review effort 2/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants