-
Notifications
You must be signed in to change notification settings - Fork 349
.metadata.name and .spec missing creating RolloutMgr (#6029)
#830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.metadata.name and .spec missing creating RolloutMgr (#6029)
#830
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
34d26ad to
42df21c
Compare
|
/retest |
Signed-off-by: Keith Chong <kykchong@redhat.com>
42df21c to
652ca99
Compare
|
/test v4.14-kuttl-sequential |
chetan-rns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
jgwest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
|
Thanks Keith, and thanks @chetan-rns for reviewing! |
…developer#830) Signed-off-by: Keith Chong <kykchong@redhat.com>
What type of PR is this?
/kind bug
What does this PR do / why we need it:
See https://issues.redhat.com/browse/GITOPS-6029
Have you updated the necessary documentation?
No
Which issue(s) this PR fixes:
Fixes #? Fixes https://issues.redhat.com/browse/GITOPS-6029
Test acceptance criteria:
How to test changes / Special notes to the reviewer: