Skip to content

Conversation

@keithchong
Copy link
Contributor

What type of PR is this?

/kind bug

What does this PR do / why we need it:

See https://issues.redhat.com/browse/GITOPS-6029

Have you updated the necessary documentation?

No

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #? Fixes https://issues.redhat.com/browse/GITOPS-6029

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Feb 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keithchong keithchong force-pushed the 6029-UpdateCSVWithArgoRolloutManagerAndRollout branch 2 times, most recently from 34d26ad to 42df21c Compare February 3, 2025 20:10
@keithchong keithchong requested a review from jgwest February 3, 2025 21:47
@keithchong
Copy link
Contributor Author

/retest

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong force-pushed the 6029-UpdateCSVWithArgoRolloutManagerAndRollout branch from 42df21c to 652ca99 Compare February 24, 2025 16:39
@chetan-rns
Copy link
Member

/test v4.14-kuttl-sequential

Copy link
Member

@chetan-rns chetan-rns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@jgwest jgwest merged commit 768de6f into redhat-developer:master Feb 25, 2025
16 of 17 checks passed
@jgwest
Copy link
Member

jgwest commented Feb 25, 2025

Thanks Keith, and thanks @chetan-rns for reviewing!

varshab1210 pushed a commit to nmirasch/gitops-operator that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants