Migrate tutorial from swapi.info/swapi.dev to swapi.build#180
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Closes redhat-developer-demos#179. - Update all swapi.info and swapi.dev API URLs in the tutorial docs and tutorial_app to point at https://swapi.build/api. - Update the fault-tolerance chapter's intentionally-broken URL from swapii.dev to swapii.build so the example stays consistent with the new base domain. - Update the readiness probe's expected status code from 200 to 202; swapi.build currently responds 202 Accepted to GET /api/films/, so the tutorial's readiness check would fail against the new backend without this change. Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179.
Summary
Migrates every Star Wars API reference in the tutorial (docs +
tutorial_app) fromswapi.info/swapi.devto the newhttps://swapi.build/apiservice that the issue points to.Changes
documentation/modules/ROOT/pages/08_rest-client.adochttps://swapi.info/...URLs (example JSON, prose,application.propertiessnippet) now usehttps://swapi.build/.... The "Create Swapi POJO" paragraph'shttp://swapi.devreference also switched tohttps://swapi.build.documentation/modules/ROOT/pages/09_fault-tolerance.adocUnknownHostExceptionoutput was updated to match.documentation/modules/ROOT/pages/10_health.adochttps://swapi.devin prose andhttps://swapi.info/api/filmsin the two expected health-endpoint JSON responses are nowswapi.build. See note below on status code.apps/tutorial_app/src/main/resources/application.propertieshttps://swapii.dev->https://swapii.buildso the fault-tolerance chapter's intentionally-broken URL stays consistent with the new base domain.Notes for reviewers
swapi.buildcurrently responds202 AcceptedtoGET /api/films/instead of200 OK. The readiness probe in10_health.adochard-codes.statusCode(200), so the tutorial's health check would always fail against the new backend without this change. I updated that one value to202. If the swapi.build team plans to move to200, this line should be updated back at that time.swapi.build(HTTP/2 202with a JSON body matching the shape shown in the tutorial).swapi.buildJSON preserves theswapi.info-style endpoints (no trailing slash, no endpoint renames), so no payload/POJO changes were needed.🤖 Generated with Claude Code