[code-quality] Add ParameterBagTypedGetMethodCallRector#834
Merged
TomasVotruba merged 4 commits intomainfrom Sep 1, 2025
Merged
[code-quality] Add ParameterBagTypedGetMethodCallRector#834TomasVotruba merged 4 commits intomainfrom
TomasVotruba merged 4 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-cleanup
branch
3 times, most recently
from
617b1f9 to
4b584f7
Compare
TomasVotruba
force-pushed
the
tv-cleanup
branch
from
4b584f7 to
3cc018d
Compare
samsonasik
reviewed
Sep 1, 2025
| } | ||
|
|
||
| private function refactorMethodCall(MethodCall $methodCall): ?MethodCall | ||
| { |
Member
There was a problem hiding this comment.
first class callable need to be skipped early
samsonasik
reviewed
Sep 1, 2025
| @@ -1,18 +0,0 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
@TomasVotruba this removal seems cause eror on rector-phpunit rector run:
[ERROR] Class "Rector\Symfony\Set\FOSRestSetList" not found
Member
There was a problem hiding this comment.
Removing usage at rector-src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref symfony/symfony#48525
use Symfony\Component\HttpFoundation\Request; final class GetOnBoolean { public function run(Request $request) { - $debug = (bool) $request->query->get('debug', false); + $debug = $request->query->getBoolean('debug'); } }