Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -467,5 +467,12 @@ parameters:

# false positive
-
identifier: phpstanApi.varTagAssumption
path: rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php
identifier: phpstanApi.varTagAssumption
path: rules/TypeDeclarationDocblocks/Rector/ClassMethod/AddReturnDocblockForDimFetchArrayFromAssignsRector.php

# bug, fix in symplify/phpstan-rules
-
identifier: symplify.noMissnamedDocTag
paths:
- rules/Php74/NodeAnalyzer/ClosureArrowFunctionAnalyzer.php
- rules/TypeDeclarationDocblocks/TypeResolver/ConstantArrayTypeGeneralizer.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;

abstract class HandlePrivateAbstract
{
private const VALUE = 1000;
}
?>
-----
<?php

namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;

abstract class HandlePrivateAbstract
{
private const int VALUE = 1000;
}
?>
8 changes: 4 additions & 4 deletions rules/Php83/Rector/ClassConst/AddTypeToConstRector.php
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ public function refactor(Node $node): ?Class_
return null;
}

if ($node->isAbstract()) {
return null;
}

$classConsts = $node->getConstants();
if ($classConsts === []) {
return null;
Expand All @@ -99,6 +95,10 @@ public function refactor(Node $node): ?Class_
}

foreach ($classConst->consts as $constNode) {
if ($node->isAbstract() && ! $classConst->isPrivate()) {
continue;
}

if ($this->isConstGuardedByParents($constNode, $parentClassReflections)) {
continue;
}
Expand Down