Skip to content
/ rector-src Public

[Php80] Skip different type param and property type on ClassPropertyAssignToConstructorPromotionRector #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samsonasik wants to merge 2 commits into from
Closed

[Php80] Skip different type param and property type on ClassPropertyAssignToConstructorPromotionRector #7763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e08cff9
[Php80] Skip different type param and property type on ClassPropertyA…
samsonasik Dec 19, 2025
e4f44c0
fix test
samsonasik Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...nToConstructorPromotionRector/Fixture/skip_different_type_property_and_param_type.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector\Fixture;

class SkipDifferentTypePropertyAndParamType
{
private ?\stdClass $customerInput;

public function __construct(
\stdClass $customerInput,
) {
$this->customerInput = $customerInput;
}

public function markResolved(): void
{
$this->customerInput = null;
}
}
8 changes: 8 additions & 0 deletions rules/Php80/NodeAnalyzer/PromotedPropertyCandidateResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Rector\Php80\NodeAnalyzer;

use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\Variable;
Expand Down Expand Up @@ -131,6 +132,13 @@ private function matchPropertyPromotionCandidate(
continue;
}

if ($property->type instanceof Node
&& $matchedParam->type instanceof Node
&& ! $matchedParam->default instanceof Expr
&& ! $this->nodeComparator->areNodesEqual($matchedParam->type, $property->type)) {
continue;
}

if ($this->shouldSkipParam($matchedParam, $assignedExpr, $firstParamAsVariable)) {
continue;
}
Expand Down