[performance-test] node static map vs is_a() check of node type #7637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wonder whether this is the fastest way to mach a
$nodeobject againstgetNodeTypes()string node-class types.As we do now in
RectorNodeTraverser:Alternative approach - constant map
FunctionLike::class => [ClassMethod::class, Function_::class]...and in_array()I'm dumping the script here, so we know how it performs, and have comparison for the future. + For anyone who might be interasted in real numbers :)
Run
Results
The
is_a()is still fastest way to check node type, by ~20 % ✔️