Skip to content
/ rector-src Public

[CodingStyle] Do not use FullyQualified on "self" on ClosureFromCallableToFirstClassCallableRector #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Nov 17, 2025
Merged

[CodingStyle] Do not use FullyQualified on "self" on ClosureFromCallableToFirstClassCallableRector #7632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b2479
fix #9493
devnix Nov 17, 2025
a752711
early check FullyQualified
samsonasik Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ...l/ClosureFromCallableToFirstClassCallableRector/Fixture/supports_static_self_call.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

class Foo
{
public static function bar(): void
{
set_exception_handler(Closure::fromCallable([self::class, 'baz']));
}

public static function baz(): void
{
}
}

?>
-----
<?php

class Foo
{
public static function bar(): void
{
set_exception_handler(self::baz(...));
}

public static function baz(): void
{
}
}

?>
7 changes: 6 additions & 1 deletion rules/CodingStyle/Rector/FuncCall/ClosureFromCallableToFirstClassCallableRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ public function refactor(Node $node): ?Node
return null;
}

$classNode = new FullyQualified($array->items[0]->value->class->name);
if ($array->items[0]->value->class instanceof FullyQualified) {
$classNode = new FullyQualified($array->items[0]->value->class->name);
} else {
$classNode = new Name($array->items[0]->value->class->name);
}

} elseif ($array->items[0]->value instanceof FullyQualified) {
$classNode = new FullyQualified($array->items[0]->value->name);
} else {
Expand Down