Skip to content
/ rector-src Public

fallback to var float #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Oct 28, 2025
Merged

fallback to var float #7601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09729f6
fallback to var
TomasVotruba Oct 28, 2025
f5558c0
[ci-review] Rector Rectify
actions-user Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ...Class_/TypedPropertyFromJMSSerializerAttributeTypeRector/Fixture/string_var_float.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?php

namespace Rector\Tests\TypeDeclaration\Rector\Class_\TypedPropertyFromJMSSerializerAttributeTypeRector\Fixture;

use JMS\Serializer\Annotation\Type;

final class StringVarFloat
{
/**
* @var float
*/
#[Type('string')]
private $price;
}

?>
-----
<?php

namespace Rector\Tests\TypeDeclaration\Rector\Class_\TypedPropertyFromJMSSerializerAttributeTypeRector\Fixture;

use JMS\Serializer\Annotation\Type;

final class StringVarFloat
{
#[Type('string')]
private ?float $price = null;
}

?>
24 changes: 15 additions & 9 deletions rules/TypeDeclaration/Rector/Class_/TypedPropertyFromJMSSerializerAttributeTypeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\Property;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\FloatType;
use PHPStan\Type\MixedType;
use PHPStan\Type\ObjectType;
use PHPStan\Type\StringType;
use PHPStan\Type\Type;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
use Rector\DeadCode\PhpDoc\TagRemover\VarTagRemover;
Expand Down Expand Up @@ -97,8 +97,6 @@ public function provideMinPhpVersion(): int
*/
public function refactor(Node $node): ?Node
{
$hasChanged = false;

if (! $this->hasAtLeastOneUntypedPropertyUsingJmsAttribute($node)) {
return null;
}
Expand All @@ -108,6 +106,8 @@ public function refactor(Node $node): ?Node
return null;
}

$hasChanged = false;

foreach ($node->getProperties() as $property) {
if ($this->shouldSkipProperty($property, $classReflection)) {
continue;
Expand Down Expand Up @@ -180,13 +180,19 @@ private function createTypeNode(string $typeValue, Property $property): ?Node
{
if ($typeValue === 'float') {
$propertyPhpDocInfo = $this->phpDocInfoFactory->createFromNode($property);
if ($propertyPhpDocInfo instanceof PhpDocInfo) {
// fallback to string, as most likely string representation of float
if ($propertyPhpDocInfo->getVarType() instanceof StringType) {
$this->varTagRemover->removeVarTag($property);
// fallback to string, as most likely string representation of float
if ($propertyPhpDocInfo instanceof PhpDocInfo && $propertyPhpDocInfo->getVarType() instanceof StringType) {
$this->varTagRemover->removeVarTag($property);
return new Identifier('string');
}
}

return new Identifier('string');
}
if ($typeValue === 'string') {
$propertyPhpDocInfo = $this->phpDocInfoFactory->createFromNode($property);
// fallback to string, as most likely string representation of float
if ($propertyPhpDocInfo instanceof PhpDocInfo && $propertyPhpDocInfo->getVarType() instanceof FloatType) {
$this->varTagRemover->removeVarTag($property);
return new Identifier('float');
}
}

Expand Down