Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Oct 23, 2025

  • move internal /bin files to /scripts, to separate from public /bin API
  • decouple script helpers
  • [ci] add short class fixture names check to avoid node class names

@TomasVotruba TomasVotruba changed the title tv bin check short [ci] add short class fixture names check to avoid node class names Oct 23, 2025
@TomasVotruba TomasVotruba force-pushed the tv-bin-check-short branch 2 times, most recently from fe0a88a to b4f559b Compare October 23, 2025 13:28
@@ -1,51 +0,0 @@
<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixture test is needed, I can create separate PR for update fixture with new class name to not conflict with Node name :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We already have this case covered. I remove these fixtures on purpose, to make tests more readable and maintainable.

Copy link
Member

@samsonasik samsonasik Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, loop of multi properties is special :), because it already too early imported on class level, I will find a referenced PR :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsonasik It should at least re-use existing configuration. No need to add new configuration item, morever of non-existing class. That makes test less readable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I will add to use existing config 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,36 +0,0 @@
<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixture test is needed, I can create separate PR for update fixture with new class name to not conflict with Node name :)

Copy link
Member Author

@TomasVotruba TomasVotruba Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on purpose, not to create fixture per every possible item, but make them readable.
Don't add anything here.

@TomasVotruba TomasVotruba merged commit 4e0b912 into main Oct 23, 2025
53 checks passed
@TomasVotruba TomasVotruba deleted the tv-bin-check-short branch October 23, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants