Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
naming: true,
instanceOf: true,
earlyReturn: true,
strictBooleans: true,
rectorPreset: true,
phpunitCodeQuality: true
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromo
final class DoNotRemoveParameterAttribute
{
public function __construct(
#[\SensitiveParameter]private string $password
#[\SensitiveParameter] private string $password
)
{
}
Expand Down
4 changes: 2 additions & 2 deletions rules/Php82/NodeManipulator/ReadonlyClassManipulator.php
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ private function shouldSkipClass(Class_ $class): bool
}

return $class->extends instanceof FullyQualified && ! $this->reflectionProvider->hasClass(
$class->extends->toString()
);
$class->extends->toString()
);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion rules/Php83/Rector/Class_/ReadOnlyAnonymousClassRector.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function refactor(Node $node): ?Node
return null;
}

return $this->readonlyClassManipulator->process($node, $this->file);
return $this->readonlyClassManipulator->process($node);
}

public function provideMinPhpVersion(): int
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use PhpParser\Node;
use PhpParser\Node\Stmt\Class_;
use PHPStan\Reflection\ReflectionProvider;
use Rector\Php81\NodeManipulator\AttributeGroupNewLiner;
use Rector\Privatization\NodeManipulator\VisibilityManipulator;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
Expand All @@ -20,8 +19,7 @@ final class FinalizeTestCaseClassRector extends AbstractRector
{
public function __construct(
private readonly ReflectionProvider $reflectionProvider,
private readonly VisibilityManipulator $visibilityManipulator,
private readonly AttributeGroupNewLiner $attributeGroupNewLiner
private readonly VisibilityManipulator $visibilityManipulator
) {
}

Expand Down Expand Up @@ -85,10 +83,6 @@ public function refactor(Node $node): ?Node
return null;
}

if ($node->attrGroups !== []) {
$this->attributeGroupNewLiner->newLine($this->file, $node);
}

$this->visibilityManipulator->makeFinal($node);

return $node;
Expand Down
Loading