[code-quality] Add ReplaceConstantBooleanNotRector #7527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A negated constant boolean can be trivially changed to the other constant boolean.
class IfCondition { public function run() { - if (!true) { + if (false) { return true; } return false; } }I am using this in tandem with bootstrapped constants. It allows dead code elimination rectors to remove blocks of code when the appropriate constants are defined.