[Php84] Skip has mix between normal property and readonly promoted property on PropertyHookRector #7504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropertyHookRector
samsonasik
changed the title
Member
Author
|
Fixed 🎉 /cc @TomasVotruba |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
| return []; | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
After some various check, this seems ok to have it mix, as we can't redeclare both in prop and property promotion.
I am reverting it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this PR covers:
so should be skipped as well, ref #7498 (review)