[DeadCode] Skip native function with side effect on RemoveConditionExactReturnRector

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/skip_side_effect_native.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class SkipSideEffectNativeFunction
+{
+    public function run($result)
+    {
+        if ($result === array_push($result, 100)) {
+            return array_push($result, 100);
+        }
+
+        return $result;
+    }
+}

rules/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Stmt\If_;
 use PhpParser\Node\Stmt\Return_;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
+use Rector\DeadCode\SideEffect\SideEffectNodeDetector;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -22,6 +23,11 @@
  */
 final class RemoveConditionExactReturnRector extends AbstractRector
 {
+    public function __construct(
+        private readonly SideEffectNodeDetector $sideEffectNodeDetector
+    ) {
+    }
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -94,12 +100,8 @@ public function refactor(Node $node): ?Node
             }
 
             $identicalOrEqual = $stmt->cond;
-            // skip obvious complexity
-            if ($identicalOrEqual->right instanceof MethodCall) {
-                continue;
-            }
 
-            if ($identicalOrEqual->right instanceof StaticCall) {
+            if ($this->sideEffectNodeDetector->detect($identicalOrEqual->right)) {
                 continue;
             }