Skip to content
/ rector-src Public

[Alternative] Use direct check to avoid redeclare function isPHPStanTestPreloaded() #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samsonasik wants to merge 2 commits into from
Closed

[Alternative] Use direct check to avoid redeclare function isPHPStanTestPreloaded() #7461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3468bc1
[Alternative] Use direct check to avoid redeclare function isPHPStanT…
samsonasik Oct 10, 2025
fdb94ba
[Alternative] Use direct check to avoid redeclare function isPHPStanT…
samsonasik Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions build/build-preload.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,11 @@ final class PreloadBuilder
// edge case during Rector tests case, happens when
// 1. phpstan autoload test case is triggered first,
// 2. all php-parser classes are loaded,
if (defined('PHPUNIT_COMPOSER_INSTALL') && isPHPStanTestPreloaded()) {
if (defined('PHPUNIT_COMPOSER_INSTALL')
&& class_exists(PHPStanTestCase::class, false)
&& interface_exists(Node::class, false)) {
return;
}

function isPHPStanTestPreloaded(): bool
{
if (! class_exists(PHPStanTestCase::class, false)) {
return false;
}

return interface_exists(Node::class, false);
}
CODE_SAMPLE;

/**
Expand Down
13 changes: 3 additions & 10 deletions preload-split-package.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,12 @@
// edge case during Rector tests case, happens when
// 1. phpstan autoload test case is triggered first,
// 2. all php-parser classes are loaded,
if (defined('PHPUNIT_COMPOSER_INSTALL') && isPHPStanTestPreloaded()) {
if (defined('PHPUNIT_COMPOSER_INSTALL')
&& class_exists(PHPStanTestCase::class, false)
&& interface_exists(Node::class, false)) {
return;
}

function isPHPStanTestPreloaded(): bool
{
if (! class_exists(PHPStanTestCase::class, false)) {
return false;
}

return interface_exists(Node::class, false);
}

require_once __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/Node.php';
require_once __DIR__ . '/src/Contract/PhpParser/Node/StmtsAwareInterface.php';
require_once __DIR__ . '/../../../vendor/nikic/php-parser/lib/PhpParser/NodeAbstract.php';
Expand Down
13 changes: 3 additions & 10 deletions preload.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,12 @@
// edge case during Rector tests case, happens when
// 1. phpstan autoload test case is triggered first,
// 2. all php-parser classes are loaded,
if (defined('PHPUNIT_COMPOSER_INSTALL') && isPHPStanTestPreloaded()) {
if (defined('PHPUNIT_COMPOSER_INSTALL')
&& class_exists(PHPStanTestCase::class, false)
&& interface_exists(Node::class, false)) {
return;
}

function isPHPStanTestPreloaded(): bool
{
if (! class_exists(PHPStanTestCase::class, false)) {
return false;
}

return interface_exists(Node::class, false);
}

require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/Node.php';
require_once __DIR__ . '/src/Contract/PhpParser/Node/StmtsAwareInterface.php';
require_once __DIR__ . '/vendor/nikic/php-parser/lib/PhpParser/NodeAbstract.php';
Expand Down