[ci] Run PHPUnit 12 and PHPStan compatibilty check #7455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-ci-test-compat
branch
3 times, most recently
from
cf90abe to
a2e4d82
Compare
Member
|
PR title need to be updated as "PHPUnit 12", not "PHPStan 12" |
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-ci-test-compat
branch
from
a2e4d82 to
d12e5f4
Compare
TomasVotruba
force-pushed
the
tv-ci-test-compat
branch
from
d12e5f4 to
e6d6fd1
Compare
Member
Author
|
Let's ship this 👍 |
samsonasik
reviewed
Oct 10, 2025
| php-version: 8.2 | ||
| coverage: none | ||
|
|
||
| - run: composer create-project "rector/rector-compat-tests:dev-main" . |
Member
There was a problem hiding this comment.
The rector/rector-compat-tests uses "rector/rector" dev-main, which new PR is different with existing downgraded "rector/rector" dev-main -> that require merged first and then we can see another verify in next another PR.
I think we need mechanism that it apply on each PR created:
- downgrade rector-src into specific "folder" eg: "rector-scoped-testing"
- use that
rector-scoped-testingat rector/rector-compat-tests, eg: require rector-rector-src:dev-main#some-hash-PR
Member
Author
There was a problem hiding this comment.
That's expected, as we only care about final product, downgraded and preloaded rector/rector.
The rector-src always worked, so it was not the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compat test to run in CI right here.
Ref https://github.com/rectorphp/rector-compat-tests
Ref rectorphp/rector#9416