[TypeDeclaration] Handle with other method from parent on KnownMagicClassMethodTypeRector #7423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lassMethodTypeRector
Member
Author
|
Fixed 🎉 /cc @TomasVotruba |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
TomasVotruba
reviewed
Oct 4, 2025
| "rules-tests/CodingStyle/Rector/Namespace_/ImportFullyQualifiedNamesRector/Source", | ||
| "rules-tests/Renaming/Rector/Name/RenameClassRector/Source" | ||
| "rules-tests/Renaming/Rector/Name/RenameClassRector/Source", | ||
| "rules-tests/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector/Source" |
Member
There was a problem hiding this comment.
This should not be needed. The class respects PSR-4, right?
Member
Author
There was a problem hiding this comment.
It is weird that without it, it doesn't work on this case, probably some sort order issue or some case sensitive typo, but double check without add to classmap, use previous return null, then run "composer update", and error happen
Member
Author
There was a problem hiding this comment.
Ok, I got it, the class name is different with file name:
-abstract class ParentClassWithOtherMethod
+abstract class ParentClassOtherMethodas file name is named ParentClassOtherMethod, I will create new PR for it.
Member
Author
There was a problem hiding this comment.
I created new PR for it:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #7422 (review)