Skip to content
/ rector-src Public

[CodeQuality] Avoid too early findInstanceOf() usage on RepeatedOrEqualToInArrayRector #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 1 commit into from
Oct 2, 2025
Merged

[CodeQuality] Avoid too early findInstanceOf() usage on RepeatedOrEqualToInArrayRector #7401

samsonasik merged 1 commit into from
Oct 2, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 2, 2025 •
edited
Loading

move to before its usage.

@samsonasik samsonasik enabled auto-merge (squash) October 2, 2025 23:17
@samsonasik samsonasik merged commit 73031f7 into main Oct 2, 2025
50 checks passed
@samsonasik samsonasik deleted the avoid-too-early-find branch October 2, 2025 23:18
@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 3, 2025

Thanks. Could we have this one as Rector rule? I saw this pattern so many times

@samsonasik
Copy link
Member Author

samsonasik commented Oct 3, 2025

@TomasVotruba we had MoveVariableDeclarationNearReferenceRector in the past, and you removed it at PR:

@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 3, 2025

I see :) the nested reference is a problem indeed. Thanks, let's skip this one then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba