Skip to content
/ rector-src Public

[TypeDeclarationDocblocks] Allow override dummy mixed identifier on UsefulArrayTagNodeAnalyzer #7395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 1 commit into from
Oct 1, 2025
Merged

[TypeDeclarationDocblocks] Allow override dummy mixed identifier on UsefulArrayTagNodeAnalyzer #7395

TomasVotruba merged 1 commit into from
Oct 1, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Oct 1, 2025

@TomasVotruba let's improve UsefulArrayTagNodeAnalyzer to allow dummy mixed identifier, which mostly won't be used as Templated Tag:

    /**
-    * @return mixed
+    * @return int[][]
     */

@samsonasik
Copy link
Member Author

samsonasik commented Oct 1, 2025

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 1, 2025

LGTM 👍

@TomasVotruba TomasVotruba merged commit b5d1075 into main Oct 1, 2025
50 checks passed
@TomasVotruba TomasVotruba deleted the override-dummy-mixed-identifier branch October 1, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba