[type-declarations] Open isset check in StrictArrayParamDimFetchRectorTest, move to last position in type-declaration level

[TomasVotruba]

In one project I've noticed there is no array filled where obviously should be one.
Single isset might be triggered on null and key, but maybe more useful cases are ignored then. Let's open up this a bit and test in the wild, if brings more value 👍

[samsonasik]

There is rule StrictArrayParamDimFetchRector rule for it, for 0 index without context, it can be string, which maybe not array on purpose, see

rector-src/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php

Lines 173 to 177 in edadebb

	// skip integer in possibly string type as string can be accessed via int
	$dimType = $this->getType($node->dim);
	if ($dimType->isInteger()->yes() && $variableType->isString()->maybe()) {
	return null;
	}

see https://3v4l.org/8h8nm

[TomasVotruba]

I could not find this one, thanks

I see lot of missed array types just to avoid string access. Will make this condition less strict to improve auto fill 👍

[samsonasik]

Then that's need on very last on level set list with Int_ key, as risky, or just not register in the set list, user can manually use this rule when needed.

Also, still needs ParentClassMethodTypeOverrideGuard->hasParentClassMethod() check still needed.

[staabm]

in this case $param could be anything which implements ArrayAccess not just the rare case of string-offset access.

in case you "wrongly guess" the array type a call with a ArrayAccess object will produce a fatal error at runtime - see https://3v4l.org/csROV

[TomasVotruba]

Indeed, it's a choice of practice over risk of few edge cases. We apply same logic to other rules too, to ease manual daunting work on project upgrades.

If your codebase uses any type in this case, exclude the rule.

[TomasVotruba]

Indeed, it's a choice of practice over risk of few edge cases. We apply same logic to other rules too, to ease manual daunting work on project upgrades.

If your codebase uses any type in this case, exclude the rule.