Skip to content
/ rector-src Public

[TypeDeclarationDocblocks] Allow override dummy array var on DocblockVarFromParamDocblockInConstructorRector #7384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Oct 1, 2025
Merged

[TypeDeclarationDocblocks] Allow override dummy array var on DocblockVarFromParamDocblockInConstructorRector #7384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .../DocblockVarFromParamDocblockInConstructorRector/Fixture/override_dummy_array_var.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php

namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\DocblockVarFromParamDocblockInConstructorRector\Fixture;

final class OverrideDummyArrayVar
{
/**
* @var array
*/
private array $names = [];

/**
* @param string[] $names
*/
public function __construct(array $names)
{
$this->names = $names;
}
}

?>
-----
<?php

namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\DocblockVarFromParamDocblockInConstructorRector\Fixture;

final class OverrideDummyArrayVar
{
/**
* @var string[]
*/
private array $names = [];

/**
* @param string[] $names
*/
public function __construct(array $names)
{
$this->names = $names;
}
}

?>
5 changes: 3 additions & 2 deletions ...ypeDeclarationDocblocks/Rector/Class_/DocblockVarFromParamDocblockInConstructorRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Property;
use PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode;
use PHPStan\Type\ArrayType;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
use Rector\Rector\AbstractRector;
use Rector\TypeDeclarationDocblocks\NodeAnalyzer\ConstructorAssignedTypeResolver;
use Rector\TypeDeclarationDocblocks\NodeDocblockTypeDecorator;
use Rector\TypeDeclarationDocblocks\TagNodeAnalyzer\UsefulArrayTagNodeAnalyzer;
use Rector\ValueObject\MethodName;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
Expand All @@ -26,6 +26,7 @@ final class DocblockVarFromParamDocblockInConstructorRector extends AbstractRect
public function __construct(
private readonly PhpDocInfoFactory $phpDocInfoFactory,
private readonly ConstructorAssignedTypeResolver $constructorAssignedTypeResolver,
private readonly UsefulArrayTagNodeAnalyzer $usefulArrayTagNodeAnalyzer,
private readonly NodeDocblockTypeDecorator $nodeDocblockTypeDecorator
) {
}
Expand Down Expand Up @@ -96,7 +97,7 @@ public function refactor(Node $node): ?Node
$propertyPhpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($property);

// @var tag already given
if ($propertyPhpDocInfo->getVarTagValueNode() instanceof VarTagValueNode) {
if ($this->usefulArrayTagNodeAnalyzer->isUsefulArrayTag($propertyPhpDocInfo->getVarTagValueNode())) {
continue;
}

Expand Down