Cover named args in ClassMethodArrayDocblockParamFromLocalCallsRector #7357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
samsonasik
reviewed
Sep 28, 2025
| foreach ($call->args as $position => $arg) { | ||
| if ($this->shouldSkipArg($arg)) { | ||
| return []; | ||
| continue; |
Member
There was a problem hiding this comment.
return [] was right, when there is a first class callable or unpack in list of calls, should be immediatelly stop all together since we don't know what the arg passed allowed.
I will create new PR for it.
Member
There was a problem hiding this comment.
samsonasik
reviewed
Sep 28, 2025
| $positionOrName = $position; | ||
| } | ||
|
|
||
| $staticTypesByArgumentPosition[$positionOrName][] = $this->resolveArgValueType($arg); |
Member
There was a problem hiding this comment.
There is ArgsAnalyzer->resolveArgPosition()
I will create a PR for it.
Member
There was a problem hiding this comment.
nvm, seems ok on this case 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.