[TypeDeclarationDocblocks] Handle nested false and true on DocblockReturnArrayFromDirectArrayInstanceRector #7354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l on DocblockReturnArrayFromDirectArrayInstanceRector
samsonasik
changed the title
Member
Author
|
Use both |
samsonasik
changed the title
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
| namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector\Fixture; | ||
|
|
||
| /** | ||
| * @return array<string, true[]|false[]> |
Member
There was a problem hiding this comment.
I think in this case, the bool[] would be more clear
Member
Author
There was a problem hiding this comment.
Yes, as I commented before #7354 (comment), it can be improved in separate PR
Member
Author
There was a problem hiding this comment.
I created improvement PR for it:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://getrector.com/demo/5665e0bc-52b5-4515-815d-ac9f1984811a
It currently only show
false