Skip to content
/ rector-src Public

[TypeDeclarationDocblock] clean up recursive mixed check, only in first union to avoid deep mixed removed #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Sep 27, 2025
Merged

[TypeDeclarationDocblock] clean up recursive mixed check, only in first union to avoid deep mixed removed #7341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,16 @@ private function unionToSingleType(array $staticTypesByArgumentPosition, bool $r

if ($staticTypeByArgumentPosition[$position] instanceof UnionType) {
foreach ($staticTypeByArgumentPosition[$position]->getTypes() as $subType) {
// has another type over mixed is not allowed, even on native type
if ($subType instanceof MixedType) {
$staticTypeByArgumentPosition[$position] = new MixedType();
continue 2;
}

if ($removeMixedArray && $subType instanceof ArrayType && $this->isArrayMixedMixedType($subType)) {
$staticTypeByArgumentPosition[$position] = new MixedType();
continue 2;
}
}
}
}
Expand Down Expand Up @@ -228,14 +234,6 @@ private function isEmptyArray(Expr $expr): bool
private function isArrayMixedMixedType(Type $type): bool
{
if (! $type instanceof ArrayType) {
if ($type instanceof UnionType) {
foreach ($type->getTypes() as $subType) {
if ($subType instanceof ArrayType && $this->isArrayMixedMixedType($subType)) {
return true;
}
}
}

return false;
}

Expand Down
Loading