Skip to content
/ rector-src Public

[TypeDeclarationDocblocks] Skip mixed[] array from getter on ClassMethodArrayDocblockParamFromLocalCallsRector #7340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 2 commits into from
Sep 26, 2025
Merged

[TypeDeclarationDocblocks] Skip mixed[] array from getter on ClassMethodArrayDocblockParamFromLocalCallsRector #7340

samsonasik merged 2 commits into from
Sep 26, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 26, 2025

It currently cause:

+    /**
+     * @param mixed[] $p
+     */

which should be skipped.

Ref https://getrector.com/demo/d69d787b-ecf3-4ddc-ba31-b9024c8d30cb

@samsonasik
Copy link
Member Author

samsonasik commented Sep 26, 2025

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

samsonasik commented Sep 26, 2025

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik enabled auto-merge (squash) September 26, 2025 18:48
@samsonasik samsonasik merged commit df78547 into main Sep 26, 2025
50 checks passed
@samsonasik samsonasik deleted the skip-mixed-from-getter branch September 26, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik