Skip to content
/ rector-src Public

[TypeDeclarationDocblocks] Skip mixed|mixed[] on ClassMethodArrayDocblockParamFromLocalCallsRector #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 7 commits into from
Sep 26, 2025
Merged

[TypeDeclarationDocblocks] Skip mixed|mixed[] on ClassMethodArrayDocblockParamFromLocalCallsRector #7338

samsonasik merged 7 commits into from
Sep 26, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 26, 2025

It currently cause

+    /**
+     * @param mixed|mixed[] $argv
+     */

https://getrector.com/demo/e3b82d99-3b41-41ef-a4c1-b77c18506e0e

which should be skipped.

@samsonasik
Copy link
Member Author

samsonasik commented Sep 26, 2025

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

samsonasik commented Sep 26, 2025

I will check if there is better solution to verify ...

@samsonasik samsonasik marked this pull request as draft September 26, 2025 17:55
@samsonasik samsonasik marked this pull request as ready for review September 26, 2025 18:09
@samsonasik
Copy link
Member Author

samsonasik commented Sep 26, 2025

Fixed.

@samsonasik
Copy link
Member Author

samsonasik commented Sep 26, 2025

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik enabled auto-merge (squash) September 26, 2025 18:11
@samsonasik samsonasik merged commit 1bdae03 into main Sep 26, 2025
50 checks passed
@samsonasik samsonasik deleted the skip-mixed-array branch September 26, 2025 18:11
TomasVotruba
TomasVotruba reviewed Sep 26, 2025
View reviewed changes
rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php
}
}
}
}
Copy link
Member

@TomasVotruba TomasVotruba Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool approach 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba