Skip to content
/ rector-src Public

Avoid spreadding mixed type in ClassMethodArrayDocblockParamFromLocalCallsRector #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Sep 26, 2025
Merged

Avoid spreadding mixed type in ClassMethodArrayDocblockParamFromLocalCallsRector #7335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions .../ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/mixed_from_unserialize.php.inc
View file
Open in desktop

This file was deleted.

15 changes: 15 additions & 0 deletions ...ector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/skip_mixed.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\ClassMethodArrayDocblockParamFromLocalCallsRector\Fixture;

final class SkipMixed
{
public function go(array $mixed)
{
$this->run($mixed);
}

private function run(array $items)
{
}
}
4 changes: 4 additions & 0 deletions ...eDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use PhpParser\Node;
use PhpParser\Node\Stmt\Class_;
use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
use PHPStan\Type\MixedType;
use PHPStan\Type\Type;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
use Rector\PhpParser\NodeFinder\LocalMethodCallFinder;
Expand Down Expand Up @@ -111,6 +112,9 @@ public function refactor(Node $node): ?Node
if (! $resolvedParameterType instanceof Type) {
continue;
}
if ($resolvedParameterType instanceof MixedType) {
continue;
}

$hasClassMethodChanged = $this->nodeDocblockTypeDecorator->decorateGenericIterableParamType(
$resolvedParameterType,
Expand Down
Loading