-
-
Notifications
You must be signed in to change notification settings - Fork 431
[Renaming] Handle namespaced annotation on RenameClassRector #7333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixed 🎉 /cc @simonschaufi |
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) For note: @simonschaufi this patch ensure we got same |
|
Wow, you really impressed me that you could fix it so quickly. I guess you had to debug quite a lot to understand what is going on here. Thank you very much! I have one wish: Please don't close the next issue so quickly but give me some time to respond. |
|
Yes, that was a nightmare 😅 Well, I can't promise on that 😎 |
|
I'm proud of you! Do you have a release cycle or when can I expect the next release? |
|
It usually 2 weeks to 1 month cycle, you can try dev-main and verify if there is regression |
Closes #7330