Skip to content
/ rector-src Public

[NodeTypeResolver] Handle ArrayType with intersection string on AccessoryNonEmptyArrayTypeCorrector #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Sep 26, 2025
Merged

[NodeTypeResolver] Handle ArrayType with intersection string on AccessoryNonEmptyArrayTypeCorrector #7332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af60c20
[NodeTypeResolver] Handle ArrayType with intersection string on Acce…
samsonasik Sep 26, 2025
e5ef6c6
[NodeTypeResolver] Handle ArrayType with intersection string on Acce…
samsonasik Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/NodeTypeResolver/NodeTypeCorrector/AccessoryNonEmptyArrayTypeCorrector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use PHPStan\Type\ArrayType;
use PHPStan\Type\IntersectionType;
use PHPStan\Type\MixedType;
use PHPStan\Type\StringType;
use PHPStan\Type\Type;

final class AccessoryNonEmptyArrayTypeCorrector
Expand All @@ -26,6 +27,12 @@ public function correct(Type $mainType): Type
if ($type instanceof NonEmptyArrayType) {
return new ArrayType(new MixedType(), new MixedType());
}

if ($type instanceof ArrayType
&& $type->getIterableValueType() instanceof IntersectionType
&& $type->getIterableValueType()->isString()->yes()) {
return new ArrayType(new MixedType(), new StringType());
}
}

return $mainType;
Expand Down
7 changes: 0 additions & 7 deletions src/NodeTypeResolver/NodeTypeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,11 @@
use PHPStan\Type\Constant\ConstantBooleanType;
use PHPStan\Type\Constant\ConstantStringType;
use PHPStan\Type\ErrorType;
use PHPStan\Type\IntegerType;
use PHPStan\Type\MixedType;
use PHPStan\Type\NeverType;
use PHPStan\Type\NullType;
use PHPStan\Type\ObjectType;
use PHPStan\Type\ObjectWithoutClassType;
use PHPStan\Type\StringType;
use PHPStan\Type\ThisType;
use PHPStan\Type\Type;
use PHPStan\Type\TypeCombinator;
Expand Down Expand Up @@ -180,11 +178,6 @@ public function getType(Node $node): Type
}
}

// correction for explode() that always returns array
if ($node instanceof FuncCall && $node->name instanceof Name && $node->name->toString() === 'explode') {
return new ArrayType(new IntegerType(), new StringType());
}

if ($node instanceof Ternary) {
$ternaryType = $this->resolveTernaryType($node);
if (! $ternaryType instanceof MixedType) {
Expand Down
Loading