Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php

namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector\Fixture;

final class OverrideMixed
{
/**
* @param array $items
* @return mixed[]
*/
public function process(array $items)
{
return array_map(function ($item): int {
return $item;
}, $items);
}
}

?>
-----
<?php

namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector\Fixture;

final class OverrideMixed
{
/**
* @param array $items
* @return int[]
*/
public function process(array $items)
{
return array_map(function ($item): int {
return $item;
}, $items);
}
}

?>
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector\Fixture;

final class SkipOverride
{
/**
* @param array $items
* @return positive-int[]
*/
public function process(array $items)
{
return array_map(function ($item): int {
return $item;
}, $items);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,12 @@ public function refactor(Node $node): null|Function_|ClassMethod
$functionLikePhpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);

$returnOriginalType = $functionLikePhpDocInfo->getReturnType();
if ($returnOriginalType instanceof IntersectionType && $returnOriginalType->isArray()->yes()) {

if ($returnOriginalType instanceof ArrayType && ! $returnOriginalType->getItemType() instanceof MixedType) {
return null;
}

if ($returnOriginalType instanceof IntersectionType) {
return null;
}

Expand Down
Loading