Skip to content
/ rector-src Public

[TypeDeclarationDocblocks] Skip already has @ return doc on AddReturnDocblockForCommonObjectDenominatorRector #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Sep 23, 2025
Merged

[TypeDeclarationDocblocks] Skip already has @ return doc on AddReturnDocblockForCommonObjectDenominatorRector #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...eturnDocblockForCommonObjectDenominatorRector/Fixture/skip_already_has_return_doc.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForCommonObjectDenominatorRector\Fixture;

use Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForCommonObjectDenominatorRector\Source\FirstExtension;
use Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\AddReturnDocblockForCommonObjectDenominatorRector\Source\SecondExtension;

final class SkipAlreadyHasReturnDoc
{
/**
* @return object[]
*/
public function getExtensions(): array
{
return [
new FirstExtension(),
new SecondExtension()
];
}
}
5 changes: 5 additions & 0 deletions ...arationDocblocks/Rector/ClassMethod/AddReturnDocblockForCommonObjectDenominatorRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Function_;
use PhpParser\Node\Stmt\Return_;
use PHPStan\PhpDocParser\Ast\PhpDoc\ReturnTagValueNode;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Type\ArrayType;
use PHPStan\Type\Constant\ConstantArrayType;
Expand Down Expand Up @@ -108,6 +109,10 @@ public function getNodeTypes(): array
public function refactor(Node $node): ?Node
{
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
if ($phpDocInfo->getReturnTagValue() instanceof ReturnTagValueNode) {
return null;
}

$returnType = $phpDocInfo->getReturnType();

if (! $returnType instanceof MixedType || $returnType->isExplicitMixed()) {
Expand Down
Loading