-
-
Notifications
You must be signed in to change notification settings - Fork 431
Add PostRectorInterface instance class names to list of applied rectors #7304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…use of PostRectorIntercace instance
|
Todo:
see https://github.com/rectorphp/rector-src/actions/runs/17876954158/job/50839607049#step:5:20 New skip voter when name result equal seems needed. |
|
The warning reduced with add I will create separate PR for it. |
|
I created separate PR for add there are still some warning, I will continue on it. |
|
2 Warnings to go: see https://github.com/rectorphp/rector-src/actions/runs/17877243809/job/50840264966#step:5:20 another skip voter seems needed. I will continue on it. |
|
implemented with handling no change 🎉 1dbced4 |
|
I will cherry-pick no change handling in separate PR :) |
|
I created separate PR for no change warning on |
|
Implemented 🎉 /cc @simonschaufi I will add e2e test for it :) |
|
I've added e2e test for it 946764c 👍 |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
…rely when NameImportingPostRector exists
…rely when NameImportingPostRector exists
…n UseAddingPostRector when there is add to use
|
Let's merge 👍 |
Closes #7300
Closes rectorphp/rector#9373