Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik changed the title [WIP] Add PostRectorInterface instances to list of applied rectors [WIP] Add PostRectorInterface instance class names to list of applied rectors Sep 20, 2025
@samsonasik
Copy link
Member Author

samsonasik commented Sep 20, 2025

Todo:

  • fix warning on NameImportingPostRector, avoid notice:
WARNING: On fixture file "skip_conflict_last_name_in_usage.php.inc" for test "Rector\Tests\Issues\AutoImport\AutoImportTest"
File not changed but some Rector rules applied:
 * Rector\PostRector\Rector\NameImportingPostRector

see https://github.com/rectorphp/rector-src/actions/runs/17876954158/job/50839607049#step:5:20

New skip voter when name result equal seems needed.

@samsonasik samsonasik self-assigned this Sep 20, 2025
@samsonasik
Copy link
Member Author

The warning reduced with add OriginalNameImportSkipVoter e819d8a

I will create separate PR for it.

@samsonasik
Copy link
Member Author

I created separate PR for add OriginalNameImportSkipVoter to cover the warning:

there are still some warning, I will continue on it.

@samsonasik
Copy link
Member Author

samsonasik commented Sep 20, 2025

2 Warnings to go:

WARNING: On fixture file "skip_conflict_last_name_in_usage.php.inc" for test "Rector\Tests\Issues\AutoImport\AutoImportTest"
File not changed but some Rector rules applied:
 * Rector\PostRector\Rector\NameImportingPostRector
..  244 / 4779 (  5%)
..
WARNING: On fixture file "skip_no_namespace_used_class.php.inc" for test "Rector\Tests\Issues\AutoImport\AutoImportTest"
File not changed but some Rector rules applied:
 * Rector\PostRector\Rector\NameImportingPostRector

see https://github.com/rectorphp/rector-src/actions/runs/17877243809/job/50840264966#step:5:20

another skip voter seems needed. I will continue on it.

@samsonasik samsonasik marked this pull request as ready for review September 20, 2025 14:09
@samsonasik
Copy link
Member Author

implemented with handling no change 🎉 1dbced4

@samsonasik samsonasik changed the title [WIP] Add PostRectorInterface instance class names to list of applied rectors Add PostRectorInterface instance class names to list of applied rectors Sep 20, 2025
@samsonasik
Copy link
Member Author

I will cherry-pick no change handling in separate PR :)

@samsonasik
Copy link
Member Author

I created separate PR for no change warning on NameImporter

@samsonasik
Copy link
Member Author

Implemented 🎉 /cc @simonschaufi

I will add e2e test for it :)

@samsonasik
Copy link
Member Author

I've added e2e test for it 946764c 👍

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

Let's merge 👍

@samsonasik samsonasik merged commit 0e36c35 into main Sep 20, 2025
50 checks passed
@samsonasik samsonasik deleted the apply-list-post-rector branch September 20, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post Rectors are not listed in the list of applied rules in the rectorsWithLineChanges list

4 participants