Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,13 @@ public function getGenericTagClassNames(): array
continue;
}

// add default original value
$resolvedClasses[] = $genericTagValueNode->value;
if (! str_contains($genericTagValueNode->value, '::')) {
$resolvedClasses[] = $genericTagValueNode->value;
continue;
}

// add resolved class name if any
$resolvedClass = $genericTagValueNode->getAttribute(PhpDocAttributeKey::RESOLVED_CLASS);
if ($resolvedClass === null) {
$resolvedClasses[] = $genericTagValueNode->value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
use Rector\StaticTypeMapper\Naming\NameScopeFactory;

/**
* Decorate node with fully qualified class name for generic annotations for @uses
* Decorate node with fully qualified class name for generic annotations for @uses, @used-by, and @see
* e.g. @uses Direction::*
*
* @see https://docs.phpdoc.org/guide/references/phpdoc/tags/uses.html
Expand Down Expand Up @@ -46,7 +46,7 @@ public function decorate(PhpDocNode $phpDocNode, PhpNode $phpNode): void
return null;
}

if (! in_array($node->name, ['@uses', '@used-by'], true)) {
if (! in_array($node->name, ['@uses', '@used-by', '@see'], true)) {
return null;
}

Expand Down
23 changes: 23 additions & 0 deletions tests/Issues/NoNamespaced/Fixture/skip_used_in_see.php.inc
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?php

use src\Event\Infrastructure\API\GooglePlaces\Place;

final readonly class Location
{
/**
* @param list<string> $types
*/
public function __construct(
public array $types,
) {}

/**
* Returns true if the location is a city
*
* @see Place::isCity()
*/
public function isCity() : bool
{
return in_array('locality', $this->types, true);
}
}
Loading