-
-
Notifications
You must be signed in to change notification settings - Fork 431
[TypeDeclarationDocblocks] Handle multiple objects on AddReturnDocblockDataProviderRector #7298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...Docblocks/Rector/Class_/AddReturnDocblockDataProviderRector/Fixture/multi_objects.php.inc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| <?php | ||
|
|
||
| namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\AddReturnDocblockDataProviderRector\Fixture; | ||
|
|
||
| use DateTime; | ||
| use DateTimeImmutable; | ||
| use PHPUnit\Framework\Attributes\DataProvider; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| final class MultiObjects extends TestCase | ||
| { | ||
| #[DataProvider('provideData')] | ||
| public function testSomething() | ||
| { | ||
| } | ||
|
|
||
| public static function provideData(): iterable | ||
| { | ||
| yield [[new DateTime(), 'format']]; | ||
| yield [[new DateTimeImmutable(), 'format']]; | ||
| } | ||
| } | ||
|
|
||
| ?> | ||
| ----- | ||
| <?php | ||
|
|
||
| namespace Rector\Tests\TypeDeclarationDocblocks\Rector\Class_\AddReturnDocblockDataProviderRector\Fixture; | ||
|
|
||
| use DateTime; | ||
| use DateTimeImmutable; | ||
| use PHPUnit\Framework\Attributes\DataProvider; | ||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| final class MultiObjects extends TestCase | ||
| { | ||
| #[DataProvider('provideData')] | ||
| public function testSomething() | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * @return \Iterator<array<int, array<int, (\DateTime | \DateTimeImmutable | string)>>> | ||
| */ | ||
| public static function provideData(): iterable | ||
| { | ||
| yield [[new DateTime(), 'format']]; | ||
| yield [[new DateTimeImmutable(), 'format']]; | ||
| } | ||
| } | ||
|
|
||
| ?> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -205,6 +205,16 @@ private function unwrapConstantArrayTypes(ConstantArrayType $constantArrayType): | |
| $nestedFlattenKeyType = new MixedType(); | ||
| } | ||
|
|
||
| if ($nestedFlattenItemType instanceof ConstantArrayType) { | ||
| $innerArrayTypes = $this->unwrapConstantArrayTypes($nestedFlattenItemType); | ||
| foreach ($innerArrayTypes as $innerArrayType) { | ||
| // preserve outer array -> inner array structure: array<outerKey, innerArray> | ||
| $unwrappedTypes[] = new ArrayType($nestedFlattenKeyType, $innerArrayType); | ||
| } | ||
|
|
||
| continue; | ||
| } | ||
|
Comment on lines
+208
to
+216
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this loop again to make result of inner constant array to avoid just added the last one, |
||
|
|
||
| $unwrappedTypes[] = new ArrayType($nestedFlattenKeyType, $nestedFlattenItemType); | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasVotruba I updated to use
77as max length union to show the fix, otherwise, it just\Iterator<mixed>for this fixture testhttps://github.com/rectorphp/rector-src/pull/7298/files#diff-2a2097385262575254922102ea5d5304cc01549cfcbdc51ef87c240199f2c4d5
The fix for this case is loop when inner is
ConstantArrayTypetoo.https://github.com/rectorphp/rector-src/pull/7298/files#diff-a5bab2fbc05ee30b694214b4e5b5c805297d9e916fc482845f92e70fd9bd3c06
Proven works at
https://phpstan.org/r/3a7c2934-6256-48c6-a4ba-351f42d4d0df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be tricky to keep in readable line. The longer the docblock will be, the more mess might get int. But let's give 77 a try.