[AutoImport] Optimize ClassRenamingPostRector with stop on enterNode() #7295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar with PR:
the process already done on
beforeTraverse()We stop the traversal because all the work has already been done in the beforeTraverse() function
Using STOP_TRAVERSAL is usually dangerous as it will stop the processing of all your nodes for all visitors
but since the PostFileProcessor is using direct new NodeTraverser() and traverse() for only a single
visitor per execution, using stop traversal here is safe,
ref
rector-src/src/PostRector/Application/PostFileProcessor.php
Lines 59 to 61 in fc1e742