Skip to content
/ rector-src Public

[AutoImport] Clean up Name check on ClassNameImportSkipper #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Sep 16, 2025
Merged

[AutoImport] Clean up Name check on ClassNameImportSkipper #7294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

use PhpParser\Node;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\GroupUse;
use PhpParser\Node\Stmt\Use_;
Expand Down Expand Up @@ -51,14 +50,6 @@ public function shouldSkipName(FullyQualified $fullyQualified, array $uses): boo
return $this->isFunctionOrConstantImport($fullyQualified);
}

// verify long name, as short name verify may conflict
// see test PR: https://github.com/rectorphp/rector-src/pull/6208
// ref https://3v4l.org/21H5j vs https://3v4l.org/GIHSB
$originalName = $fullyQualified->getAttribute(AttributeKey::ORIGINAL_NAME);
if ($originalName instanceof Name && $originalName->getLast() === $originalName->toString()) {
return true;
}

$stringName = $fullyQualified->toString();
$lastUseName = $fullyQualified->getLast();
$nameLastName = strtolower($lastUseName);
Expand Down
Loading