fix: ReturnTypeFromReturnNewRector #7291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
calebdw/push-munqolyzpsuw
branch
from
c5bfaec to
07f69c1
Compare
samsonasik
reviewed
Sep 15, 2025
|
|
||
| if (is_string($returnedNewClassName)) { | ||
| $node->returnType = new FullyQualified($returnedNewClassName); | ||
| $node->returnType = str_starts_with($returnedNewClassName, 'AnonymousClass') |
Member
There was a problem hiding this comment.
I think this can be covered by NodeTypeResolver itself, via ClassReflection->isAnonymous(), check in TypeTraverser::map(), see example
Member
There was a problem hiding this comment.
use getNativeType() over getType() should works for this.
Member
There was a problem hiding this comment.
I created separate PR:
to use native type, which more reliable for this strict type rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#9378
Thanks!