Skip to content
/ rector-src Public

Clean up PHPStan ignore errors #7262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Sep 13, 2025
Merged

Clean up PHPStan ignore errors #7262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,6 @@ parameters:
message: '#Function "(function_exists|dump_node)\(\)" cannot be used/left in the code#'
path: src/functions/node_helper.php

# false positive on enums
- '#Method Rector\\Console\\Command\\SetupCICommand\:\:resolveCurrentCI\(\) never returns (.*?) so it can be removed from the return type#'

# stmts aware/expression generics
- '#PhpParser\\Node\\Stmt\\Expression is not generic#'

Expand Down Expand Up @@ -271,16 +268,13 @@ parameters:
message: '#Fetching (deprecated )?class constant (.*?) of (deprecated )?class (Rector\\Set\\ValueObject\\DowngradeLevelSetList|Rector\\Symfony\\Set\\(.*?))#'
path: src/Configuration/RectorConfigBuilder.php

- '#::provideMinPhpVersion\(\) never returns \d+ so it can be removed from the return type#'

# runtime comparison
- '#Comparison operation ".*" between int<\d+, \d+> and \d+ is always true#'

# from mapper interface
- '#mapToPhpParserNode\(\) never returns PhpParser\\.* so it can be removed from the return#'

# from constant string
- '#Method Rector\\.*::providePolyfillPackage\(\) never returns#'
- '#Method Rector\\.*::filterPolyfillPackages\(\) should return array\<#'

-
Expand Down
Loading