[TypeDeclarationDocblocks] Avoid array<mixed, mixed> on return empty array on DocblockReturnArrayFromDirectArrayInstanceRector

[samsonasik]

Given the following code:

class ReturnEmpty
{
   public function run(): array
    {
        return [];
    }
}

It currently got:

+   /**
+    * @return array<mixed, mixed>
+    */
    public function run(): array

which I think it can just:

@return mixed[]

[samsonasik]

Fixed with array<int, mixed>.

For note: the behaviour seems different with other rule that uses syntax: mixed[] over array<int, mixed>

The improvement next maybe if it only int key, should not use array<int, type> syntax, use direct type[] instead for consistency.

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[ruudk]

Why return mixed[] for an empty array over array{}?

The array is empty and with array{} you say that it is.

[samsonasik]

I just know that it can use empty @return array{}

https://phpstan.org/r/81019bab-b81f-4dd5-bf21-02bed1fca955

Let see if it can be improved next to that

[calebdw]

The array key can never be mixed, at most it should be array-key

[samsonasik]

I created PR to use array shape empty on

• [TypeDeclarationDocblocks] use empty array shape array{} for returns empty array on DocblockReturnArrayFromDirectArrayInstanceRector #7289