Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php

namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector\Fixture;

final class SingleNestedLevel
{
public function getNames($value): array
{
return [
'key' => [
'subkey' => $value
],
];
}
}

?>
-----
<?php

namespace Rector\Tests\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockReturnArrayFromDirectArrayInstanceRector\Fixture;

final class SingleNestedLevel
{
/**
* @return array<string, array<string, mixed>>
*/
public function getNames($value): array
{
return [
'key' => [
'subkey' => $value
],
];
}
}

?>
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,7 @@ public function refactor(Node $node): ?Node
return null;
}

$genericKeyType = $this->constantToGenericType($returnedType->getKeyType());
$genericItemType = $this->constantToGenericType($returnedType->getItemType());

$genericTypeNode = $this->createArrayGenericTypeNode($genericKeyType, $genericItemType);
$genericTypeNode = $this->createGenericArrayTypeFromConstantArrayType($returnedType);

$returnTagValueNode = new ReturnTagValueNode($genericTypeNode, '');
$phpDocInfo->addTagValueNode($returnTagValueNode);
Expand Down Expand Up @@ -151,10 +148,29 @@ private function constantToGenericType(Type $type): Type
return new MixedType();
}

private function createArrayGenericTypeNode(Type $keyType, Type $itemType): GenericTypeNode
private function createGenericArrayTypeFromConstantArrayType(ConstantArrayType $constantArrayType): GenericTypeNode
{
$genericKeyType = $this->constantToGenericType($constantArrayType->getKeyType());

$itemType = $constantArrayType->getItemType();
if ($itemType instanceof ConstantArrayType) {
$genericItemType = $this->createGenericArrayTypeFromConstantArrayType($itemType);
} else {
$genericItemType = $this->constantToGenericType($itemType);
}

return $this->createArrayGenericTypeNode($genericKeyType, $genericItemType);
}

private function createArrayGenericTypeNode(Type $keyType, Type|GenericTypeNode $itemType): GenericTypeNode
{
$keyDocTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode($keyType);
$itemDocTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode($itemType);

if ($itemType instanceof Type) {
$itemDocTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode($itemType);
} else {
$itemDocTypeNode = $itemType;
}

return new GenericTypeNode(new IdentifierTypeNode('array'), [$keyDocTypeNode, $itemDocTypeNode]);
}
Expand Down
Loading