FinalPropertyPromotionRector

[arshidkv12]

No description provided.

[samsonasik]

I guess we need to discuss first when it actually needed, eg:

• it should only on non-final class, yes, you read it right, to enforce child to not override it, see https://3v4l.org/lKhiI/rfc#vgit.master
• if class already final, just skip
• etc (please provide other use case you can think off ) :)

[arshidkv12]

It needs Class_::class, right ?

public function getNodeTypes(): array
{
    return [Class_::class];
}

[samsonasik]

Yes

[samsonasik]

Looking at the change, it seems you're trying to change @final to native final param. I can see the reason, but this may need more discussion if it is actually needed in real project.

[arshidkv12]

Thanks for the feedback. I understand your concern. I thought converting @Final to the native final keyword would help modernize code, but I agree it might need more input from community about real-world use cases.

[samsonasik]

It seems you copy paste logic from other rules, please remove the unnecessary unrelated logic, focus only on this rule purpose, and also no need separate service for only used once logic.

[arshidkv12]

It seems you copy paste logic from other rules, please remove the unnecessary unrelated logic, focus only on this rule purpose, and also no need separate service for only used once logic.

Ok.

[arshidkv12]

Please check it

[samsonasik]

as I tell before, let it sit here for a while, this may need more discussion if it is actually needed in real project.

[TomasVotruba]

I'm thinking about this rule again, it doesn't seem to be good enough in Rector core.
Using @final is done on purpose, usually to comply with static analysis, while allowing internal reflection of mocking or proxies. So converting this to strict final is agains the logic.

This is a great candidate for local custom rule though 👍