[php 8.3] Add json_validate rule #7213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Sep 3, 2025
| * @see https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods | ||
| * @see \Rector\Tests\Php85\Rector\MethodCall\SleepToSerializeRector\SleepToSerializeRectorTest | ||
| */ | ||
| final class SleepToSerializeRector extends AbstractRector implements MinPhpVersionInterface |
Member
There was a problem hiding this comment.
you seems merge 2 PRs into single branch, use rebase to works on multiple feature branch, I created a blog post about it:
arshidkv12
force-pushed
the
json_validate_rule
branch
from
5563a7c to
8e9ea24
Compare
arshidkv12
force-pushed
the
json_validate_rule
branch
from
8e9ea24 to
1367ddf
Compare
samsonasik
approved these changes
Sep 4, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Looks good, let's try in the wild :)
Member
|
Thank you @arshidkv12 |
arshidkv12
added a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.