Skip to content

[Php84] Skip value extraction on ForeachToArray* rules#7193

Merged
samsonasik merged 2 commits intomainfrom
skip-extract
Aug 29, 2025
Merged

[Php84] Skip value extraction on ForeachToArray* rules#7193
samsonasik merged 2 commits intomainfrom
skip-extract

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 29, 2025

Fixes rectorphp/rector#9339
Ref https://3v4l.org/a7int#v8.4.12

Fixture example on ForeachToArrayAnyRector use case.

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @uncaught

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) August 29, 2025 07:46
@samsonasik samsonasik merged commit 91df931 into main Aug 29, 2025
49 checks passed
@samsonasik samsonasik deleted the skip-extract branch August 29, 2025 07:46
@TomasVotruba
Copy link
Member

👍

arshidkv12 pushed a commit to arshidkv12/rector-src that referenced this pull request Sep 4, 2025
* [Php84] Skip value extraction on ForeachToArray* rules

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ForeachToArrayAnyRector breaks code with variable extraction

3 participants