[Php85] Add ChrArgModuloRector#7190
Merged
TomasVotruba merged 11 commits intorectorphp:mainfrom Aug 31, 2025
Merged
Conversation
samsonasik
reviewed
Aug 28, 2025
rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 28, 2025
samsonasik
reviewed
Aug 28, 2025
rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr_inbond.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 28, 2025
rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr_inbond.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
requested changes
Aug 28, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
see my latest comment #7190 (comment)
samsonasik
reviewed
Aug 28, 2025
Contributor
Author
|
Please check it |
samsonasik
reviewed
Aug 29, 2025
rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 29, 2025
rules-tests/Php85/Rector/FuncCall/ChrArgModuloRector/Fixture/chr_var.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Aug 30, 2025
Member
|
Looks good to me |
samsonasik
changed the title
Member
|
Thank you, lets ship this 👍 |
arshidkv12
added a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 1, 2025
* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers --------- Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
arshidkv12
added a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers --------- Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
arshidkv12
added a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 5, 2025
* Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers * Wrap chr() argument with % 256 to avoid deprecated out-of-range integers --------- Co-authored-by: Arshid <arshid@Arshids-MacBook-Air.local>
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.