[Php85] Add ArrayKeyExistsNullToEmptyStringRector#7183
Merged
TomasVotruba merged 14 commits intorectorphp:mainfrom Aug 28, 2025
Hidden character warning
The head ref may contain hidden characters: "8.5_ArrayKey\u2026StringRector"
Merged
[Php85] Add ArrayKeyExistsNullToEmptyStringRector#7183TomasVotruba merged 14 commits intorectorphp:mainfrom
TomasVotruba merged 14 commits intorectorphp:mainfrom
Conversation
samsonasik
reviewed
Aug 28, 2025
samsonasik
reviewed
Aug 28, 2025
samsonasik
reviewed
Aug 28, 2025
samsonasik
reviewed
Aug 28, 2025
added 5 commits
August 28, 2025 14:03
samsonasik
reviewed
Aug 28, 2025
samsonasik
reviewed
Aug 28, 2025
rules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 28, 2025
samsonasik
requested changes
Aug 28, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Please run:
bin/rector && composer fix-cs
to fix CI
samsonasik
changed the title
samsonasik
reviewed
Aug 28, 2025
rules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 28, 2025
rules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 28, 2025
rules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php
Outdated
Show resolved
Hide resolved
Member
|
LGTM 👍 Thank you @arshidkv12 |
Contributor
Author
|
Thanks for the quick review. |
Member
|
|
Member
Member
|
Btw, the deprecation is not yet merged on php-src: so if in the PR not merged (likely will be merged) when php 8.5 released, we can revert this rule :) |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7180